adding a password reset system for admins#246
adding a password reset system for admins#246vlad-a-c wants to merge 3 commits intoXGDevGroup:mainfrom
Conversation
|
Reviewed and tested locally on the merge ref. All 49 tests in the three modified test files pass, plus 43 tests in The auth changes are the most valuable part: A few non-blocking observations (take or leave): nit: nit: future consideration: The editbox protocol has no masked/password input mode, so the temporary password is likely echoed and spoken by the screen reader as the admin types it. Pre-existing limitation, not introduced here, but worth filing as an issue if we ever add a self-service password change flow — it'd be the same problem at a worse blast radius. future consideration: After a successful reset the admin lands back on the user list, which matches The double trust-level check (decorator + explicit LGTM. |
since we don't have a mandatory email address entered, the only way of changing a password is for an admin to create a temp pass. i'm also thinking of making the user able to change his own password from the options menu.